DEPR: is_period_dtype, is_sparse #52642
Merged
+74
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
phofl
reviewed
Apr 14, 2023
| @@ -5226,6 +5226,7 @@ See the `Full Documentation <https://github.com/wesm/feather>`__. | |||
| Write to a feather file. | |||
|
|
|||
| .. ipython:: python | |||
| :okwarning: | |||
There was a problem hiding this comment.
What warning are these examples showing?
There was a problem hiding this comment.
i dont remember off the top of my head, just that it was one of the is_foo checks
There was a problem hiding this comment.
Does it mean pyarrow are using these methods then?
There was a problem hiding this comment.
Looks like pyarrow/pandas_compat.py:373 is using is_sparse
There was a problem hiding this comment.
Okay I think it's reasonable for them to use the isinstance check
phofl
approved these changes
Apr 22, 2023
|
thx @jbrockmendel |
Rylie-W
pushed a commit
to Rylie-W/pandas
that referenced
this pull request
May 19, 2023
Daquisu
pushed a commit
to Daquisu/pandas
that referenced
this pull request
Jul 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.is_sparse is particularly non-performant bc it uses a runtime import